Fix: Explicitly Initialize Input Refs with null for Better Type Safety #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary This PR updates the initialization of `ref<HTMLInputElement>` references by explicitly setting them to `null`. ### Changes - Updated `ref<HTMLInputElement>()` to `ref<HTMLInputElement | null>(null)`, ensuring proper type safety. - Prevents potential runtime errors by making sure `passwordInput.value` and `currentPasswordInput.value` are never `undefined`. - Aligns with Vue best practices for handling template refs. ### Why? - Without explicit `null`, TypeScript infers `undefined`, leading to potential issues when accessing `.value`. - Ensures better predictability and avoids unnecessary runtime checks. This change improves overall code reliability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the initialization of
ref<HTMLInputElement>references by explicitly setting them tonull.Changes
ref<HTMLInputElement>()toref<HTMLInputElement | null>(null), ensuring proper type safety.passwordInput.valueandcurrentPasswordInput.valueare neverundefined.Why?
null, TypeScript infersundefined, leading to potential issues when accessing.value.This change improves overall code reliability and maintainability.